Support reverse-proxy base paths - #213
Draft
DaehoYang wants to merge 5 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The application currently assumes it is mounted at
/. That breaks assets, API calls, WebSockets, local file navigation, and PWA resources when it is exposed through a path-based reverse proxy such as/proxy/5900/.This change derives the public URL prefix from
document.baseURI, so the server does not need provider-specific configuration or knowledge of the external proxy path.Validation
npm run test:unit— 16 files, 153 tests passednpm exec -- vue-tsc --noEmitnpm exec -- vite buildnpm exec -- tsup/user/<name>/proxy/4200//proxy-test/codexweb-shell-v3was createdNotes
Service worker registration remains opt-in through
VITE_ENABLE_SERVICE_WORKER=1. Root-mounted deployments continue to resolve to the same endpoints as before.